Assigned idx_remain if self.drop == False to run w/ permE aug#258
Open
jonathanrppittman wants to merge 1 commit intodivelab:dig-stablefrom
Open
Assigned idx_remain if self.drop == False to run w/ permE aug#258jonathanrppittman wants to merge 1 commit intodivelab:dig-stablefrom
jonathanrppittman wants to merge 1 commit intodivelab:dig-stablefrom
Conversation
jonathanrppittman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The do_trans() function in /sslgraph/method/contrastive/views_fn/structure.py previously used the idx_remain variable before it was assigned to anything if the class variable, drop, was False, causing an error. This change fixes this by assigning idx_remain to data.edge_index when self.drop is False. Thus, this code will now run whether self.drop is True or False.